TSL: Forces assignment of a function call if a loop is detected #31961
+86
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
sunag
added a commit
to sunag/three.js
that referenced
this pull request
Sep 29, 2025
…ed (mrdoob#31961)" This reverts commit 27bed72.
sunag
added a commit
to sunag/three.js
that referenced
this pull request
Sep 29, 2025
…ted (mrdoob#31961)" (mrdoob#31975) This reverts commit 699e1fa.
sunag
added a commit
that referenced
this pull request
Sep 29, 2025
…31974) * move fnCall out of context * Revert "move fnCall out of context" This reverts commit 0bb4985. * Reapply "TSL: Forces assignment of a function call if a loop is detected (#31961)" (#31975) This reverts commit 699e1fa. * Reapply "move fnCall out of context" This reverts commit ee71028. * Update StackNode.js * updates * Revert "updates" This reverts commit 063a2d2. * Reapply "updates" This reverts commit 3b56e1c. * Update VarNode.js * Update VarNode.js * Update VarNode.js * Update VarNode.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #31636
Description
Forces assignment of a function call if a loop is detected inside the function.
This is equivalent to using
.toVar()if calling a function without a layout without an inner loop, avoiding unwanted sub-loops.